Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oneimage] Add ":latest" to docker run script #477

Merged
merged 1 commit into from
Apr 5, 2017
Merged

[oneimage] Add ":latest" to docker run script #477

merged 1 commit into from
Apr 5, 2017

Conversation

taoyl-ms
Copy link
Contributor

@taoyl-ms taoyl-ms commented Apr 4, 2017 •
edited
Loading

To keep consistency with container info on pre-oneimage switches

@taoyl-ms taoyl-ms requested a review from qiluo-msft April 4, 2017 21:26
@jleveque
Copy link
Contributor

jleveque commented Apr 4, 2017

Just curious why the need to explicitly add the "latest" tag, as it was my understanding "latest" is the default target if no tag is specified. After searching, it appears that calling "docker run" without a tag will cause it to pull all versions of the image, even though it will actually run "latest." Is this why you're adding this, or is there another reason?

@taoyl-ms
Copy link
Contributor Author

taoyl-ms commented Apr 4, 2017 •
edited
Loading

I'm adding this because of another reason - to let docker ps show docker-xxxx:latest instead of docker-xxxx in image name column. The former one is the format we have been using in the previous versions, and some of our management playbook is depending on this schema. (For example, https://github.com/Azure/sonic-mgmt/blob/master/ansible/roles/sonic-common/tasks/sonicdocker.yml)

@lguohan
Copy link
Collaborator

lguohan commented Apr 4, 2017

retest this please

@jleveque
Copy link
Contributor

jleveque commented Apr 4, 2017 •
edited
Loading

It looks like Jenkins did not respond to the plugin webhook for this PR, therefore tests were never run, so there is nothing to retest.

The same problem seems to have occurred @ #478 and on the two most recent commits @ #464.

Jenkins was down this morning. It's back up but it seems like some functionality is still not working, e.g., this.

@lguohan
Copy link
Collaborator

lguohan commented Apr 5, 2017

Retest this please

1 similar comment
@lguohan
Copy link
Collaborator

lguohan commented Apr 5, 2017

Retest this please

@taoyl-ms taoyl-ms merged commit e0a3c2a into master Apr 5, 2017
@stcheng stcheng deleted the taoyl/patch-1-1 branch April 6, 2017 18:57
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Apr 30, 2019
@yxieca
[sonic-utilities] advance submodule head to latest
a4e7a83 
Submodule src/sonic-utilities 6ee0aea..b531934:
  > [db migrator] Introduce the DB migration infrastructure (sonic-net#519)
  > Skip INTERFACE entries w/o prefix (sonic-net#477)
  > Bring queue storm status to 'pfcwd show stats' (sonic-net#500)
  > Align PSU DB count field with the schema Spec. (sonic-net#509)
  > [scripts] remove duplicate script copying for nbrshow (sonic-net#517)
  > If fast-reboot-dump gives an error, don't continue with fast-reboot (sonic-net#515)
  > load_minigraph: restart hostcfgd (sonic-net#511)
  > [fast/warm reboot] add some sanity check before warm reboot (sonic-net#510)
  > show BPS, PPS, UTIL rates w/o previous clear (sonic-net#508)
  > In sync with our latest change, where we default failthrough to be False. (sonic-net#507)
  > Add warm-boot feature processing for wedge100bf_32x/65x platforms (sonic-net#485)
  > [generate_dump] system dump improvements (sonic-net#503)
  > [neighbor advertiser] convert int to string before concatenating (sonic-net#505)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this pull request Apr 30, 2019
Merged
yxieca added a commit that referenced this pull request Apr 30, 2019
@yxieca
[sonic-utilities] advance submodule head to latest (#2842)
df45a77 
Submodule src/sonic-utilities 6ee0aea..b531934:
  > [db migrator] Introduce the DB migration infrastructure (#519)
  > Skip INTERFACE entries w/o prefix (#477)
  > Bring queue storm status to 'pfcwd show stats' (#500)
  > Align PSU DB count field with the schema Spec. (#509)
  > [scripts] remove duplicate script copying for nbrshow (#517)
  > If fast-reboot-dump gives an error, don't continue with fast-reboot (#515)
  > load_minigraph: restart hostcfgd (#511)
  > [fast/warm reboot] add some sanity check before warm reboot (#510)
  > show BPS, PPS, UTIL rates w/o previous clear (#508)
  > In sync with our latest change, where we default failthrough to be False. (#507)
  > Add warm-boot feature processing for wedge100bf_32x/65x platforms (#485)
  > [generate_dump] system dump improvements (#503)
  > [neighbor advertiser] convert int to string before concatenating (#505)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
MichelMoriniaux pushed a commit to criteo-forks/sonic-buildimage that referenced this pull request May 28, 2019
@yxieca @MichelMoriniaux
[sonic-utilities] advance submodule head to latest (sonic-net#2842)
d8bcec3 
Submodule src/sonic-utilities 6ee0aea..b531934:
  > [db migrator] Introduce the DB migration infrastructure (sonic-net#519)
  > Skip INTERFACE entries w/o prefix (sonic-net#477)
  > Bring queue storm status to 'pfcwd show stats' (sonic-net#500)
  > Align PSU DB count field with the schema Spec. (sonic-net#509)
  > [scripts] remove duplicate script copying for nbrshow (sonic-net#517)
  > If fast-reboot-dump gives an error, don't continue with fast-reboot (sonic-net#515)
  > load_minigraph: restart hostcfgd (sonic-net#511)
  > [fast/warm reboot] add some sanity check before warm reboot (sonic-net#510)
  > show BPS, PPS, UTIL rates w/o previous clear (sonic-net#508)
  > In sync with our latest change, where we default failthrough to be False. (sonic-net#507)
  > Add warm-boot feature processing for wedge100bf_32x/65x platforms (sonic-net#485)
  > [generate_dump] system dump improvements (sonic-net#503)
  > [neighbor advertiser] convert int to string before concatenating (sonic-net#505)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
@marian-pritsak @prsunny
Skip INTERFACE entries w/o prefix (sonic-net#477)
4303b19 
The two possible key formats of INTERFACE table are:
INTERFACE|<NAME>|<PREFIX>
INTERFACE|<NAME>

The last one carries RIF information without the prefix so it has to be
omitted

Signed-off-by: Marian Pritsak <marianp@mellanox.com>
qiluo-msft added a commit that referenced this pull request Apr 29, 2021
@qiluo-msft
[sonic-swss-common] Update submodule (#7467)
e3b2a04 
Includes commits
```
f3e1085 2021-04-22 | [swig] fix ConfigDBConnector.db_name (#483) [Qi Luo]
0e2f1c0 2021-04-21 | [swig] Implement SonicV2Connector.hmset() (#480) [Qi Luo]
d18ce28 2021-04-21 | [swss-common] Add MUX Metrics Table (#482) [Tamer Ahmed]
2e5a194 2021-04-20 | Support for in-band-mgmt via management VRF (#479) [Venkatesan Mahalingam]
3e5529f 2021-04-19 | [swig] Implement TableEntryPoppable.pops() (#478) [Qi Luo]
4a3903b 2021-04-19 | Support for in-band-mgmt via management VRF. (#476) [Venkatesan Mahalingam]
fc2c734 2021-04-19 | [swig] allow threads (#477) [Qi Luo]
```
daall added a commit to daall/sonic-buildimage that referenced this pull request May 7, 2021
@daall
[202012][swss/swss-common/utilities/platform-daemons] Update submodule
a3b553e 
sonic-swss
- [flex-counters] Delay flex counters stats init for faster boot time [202012] (sonic-net#1736)

sonic-swss-common
- [swig] allow threads (sonic-net#477)

sonic-utilities
- [sfpshow] Gracefully handle improper 'specification_compliance' field (sonic-net#1594)

sonic-platform-daemons
- [xcvrd] Change the y_cable presence logic to use "mux_cable" table as identifier from Config DB (sonic-net#176)
- [xcvrd] Enhance Media Settings (sonic-net#177)

Signed-off-by: Danny Allen <daall@microsoft.com>
@daall daall mentioned this pull request May 7, 2021
Merged
4 tasks
daall added a commit that referenced this pull request May 10, 2021
@daall
[202012][swss-common/utilities/platform-daemons] Update submodule (#7563
506c0e8 
)

* [202012][swss/swss-common/utilities/platform-daemons] Update submodule

sonic-swss
- [flex-counters] Delay flex counters stats init for faster boot time [202012] (#1736)

sonic-swss-common
- [swig] allow threads (#477)

sonic-utilities
- [sfpshow] Gracefully handle improper 'specification_compliance' field (#1594)

sonic-platform-daemons
- [xcvrd] Change the y_cable presence logic to use "mux_cable" table as identifier from Config DB (#176)
- [xcvrd] Enhance Media Settings (#177)

Signed-off-by: Danny Allen <daall@microsoft.com>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
@qiluo-msft @raphaelt-nvidia
[sonic-swss-common] Update submodule (sonic-net#7467)
fd3f9f2 
Includes commits
```
f3e1085 2021-04-22 | [swig] fix ConfigDBConnector.db_name (sonic-net#483) [Qi Luo]
0e2f1c0 2021-04-21 | [swig] Implement SonicV2Connector.hmset() (sonic-net#480) [Qi Luo]
d18ce28 2021-04-21 | [swss-common] Add MUX Metrics Table (sonic-net#482) [Tamer Ahmed]
2e5a194 2021-04-20 | Support for in-band-mgmt via management VRF (sonic-net#479) [Venkatesan Mahalingam]
3e5529f 2021-04-19 | [swig] Implement TableEntryPoppable.pops() (sonic-net#478) [Qi Luo]
4a3903b 2021-04-19 | Support for in-band-mgmt via management VRF. (sonic-net#476) [Venkatesan Mahalingam]
fc2c734 2021-04-19 | [swig] allow threads (sonic-net#477) [Qi Luo]
```
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@qiluo-msft
[sonic-swss-common] Update submodule (sonic-net#7467)
dadcc37 
Includes commits
```
f3e1085 2021-04-22 | [swig] fix ConfigDBConnector.db_name (sonic-net#483) [Qi Luo]
0e2f1c0 2021-04-21 | [swig] Implement SonicV2Connector.hmset() (sonic-net#480) [Qi Luo]
d18ce28 2021-04-21 | [swss-common] Add MUX Metrics Table (sonic-net#482) [Tamer Ahmed]
2e5a194 2021-04-20 | Support for in-band-mgmt via management VRF (sonic-net#479) [Venkatesan Mahalingam]
3e5529f 2021-04-19 | [swig] Implement TableEntryPoppable.pops() (sonic-net#478) [Qi Luo]
4a3903b 2021-04-19 | Support for in-band-mgmt via management VRF. (sonic-net#476) [Venkatesan Mahalingam]
fc2c734 2021-04-19 | [swig] allow threads (sonic-net#477) [Qi Luo]
```
mssonicbld added a commit that referenced this pull request May 1, 2024
@mssonicbld
[submodule] Update submodule sonic-platform-daemons to the latest HEA…
f05bfcb 
…D automatically (#18841)

#### Why I did it
src/sonic-platform-daemons
```
* 4c5f727 - (HEAD -> 202311, origin/202311) [202311][warm/fast-reboot] Retain TRANSCEIVER_INFO/STATUS tables on deinit (#477) (4 hours ago) [Stepan Blyshchak]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taoyl-ms @jleveque @lguohan @qiluo-msft